react-native icon indicating copy to clipboard operation
react-native copied to clipboard

fix(jest-env): pass `exportConditions`

Open SimenB opened this issue 2 years ago • 5 comments

Summary

Like discussed in https://github.com/react-native-community/discussions-and-proposals/issues/509, RN should override the default node and node-addons conditions.

You might consider supporting (or just setting) customExportConditions instead, but the default of the node env should be overwritten 🙂

Changelog

[General] [Changed] - use 'react-native' export conditions in Jest environment

Test Plan

Green CI?

SimenB avatar Nov 04 '22 17:11 SimenB

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,991,606 +0
android hermes armeabi-v7a 6,368,151 +0
android hermes x86 7,404,296 +0
android hermes x86_64 7,268,306 +0
android jsc arm64-v8a 8,855,723 +0
android jsc armeabi-v7a 7,594,245 +0
android jsc x86 8,913,475 +0
android jsc x86_64 9,396,826 +0

Base commit: 44f3234d1f4d21f779f2dfb3b9dbe16249e7c9d2 Branch: main

analysis-bot avatar Nov 04 '22 18:11 analysis-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 44f3234d1f4d21f779f2dfb3b9dbe16249e7c9d2 Branch: main

analysis-bot avatar Nov 04 '22 18:11 analysis-bot

PR build artifact for 397ec9629414f00f251b8d69ca378d2c6293921e is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 04 '22 19:11 pull-bot

PR build artifact for 397ec9629414f00f251b8d69ca378d2c6293921e is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 04 '22 19:11 pull-bot

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 07 '22 14:11 facebook-github-bot