react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

chore: Add getKeyName function to codegen Parser class

Open gabrieldonadel opened this issue 2 years ago • 6 comments

Summary

This PR adds a getKeyName function to the codegen Parser class and implements it in the Flow and TypeScript parsers as requested on https://github.com/facebook/react-native/issues/34872.

Changelog

[Internal] [Added] - Add getKeyName function to codegen Parser class

Test Plan

Run yarn jest react-native-codegen and ensure CI is green

image

gabrieldonadel avatar Nov 04 '22 16:11 gabrieldonadel

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,070,038 +0
android hermes armeabi-v7a 6,442,174 +0
android hermes x86 7,485,033 +0
android hermes x86_64 7,344,612 +0
android jsc arm64-v8a 8,934,550 +0
android jsc armeabi-v7a 7,668,661 +0
android jsc x86 8,994,599 +0
android jsc x86_64 9,473,532 +0

Base commit: 5744b219c75ab6c2963d962d07edd6bf2f733662 Branch: main

analysis-bot avatar Nov 04 '22 17:11 analysis-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: bbb3a6146cc24d391843bcaf0a451a2876c14056 Branch: main

analysis-bot avatar Nov 04 '22 17:11 analysis-bot

PR build artifact for b8c9470146c02908c589f0cd0b5c2ca0e181c01e is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 04 '22 17:11 pull-bot

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 07 '22 14:11 facebook-github-bot

What do you think about adding a unit test for the TypeScript parser and for the Flow parser?

Sure @cipolleschi, that sounds like a great idea, I've just pushed a commit adding some unit tests for both Parsers.

gabrieldonadel avatar Nov 08 '22 01:11 gabrieldonadel

PR build artifact for a9d875fa39d128daa9573e48e5f0848ede0a89d6 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 08 '22 02:11 pull-bot

PR build artifact for a85d874873b6f54d785ea4f26636b997ff2f3320 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 08 '22 22:11 pull-bot

PR build artifact for 518ef9ad244eed7671fd28f65e37a774fe9e911a is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 08 '22 23:11 pull-bot

PR build artifact for 68f987d4ac16b3e69732c1732312282603fb11bb is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 09 '22 19:11 pull-bot

Hi @cipolleschi everything should've been updated now, do you mind taking another look?

gabrieldonadel avatar Nov 10 '22 13:11 gabrieldonadel

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Nov 10 '22 15:11 facebook-github-bot