react-native icon indicating copy to clipboard operation
react-native copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Refactor subclassing of RCTEventEmitter

Open cipolleschi opened this issue 3 years ago • 5 comments

Summary: This Diff remove the assert on the initializer in the EventEmitter in place of a more idiomatic check when the method is invoked.

It aims to solve an internal error and promotes best practices for the iOS platform.

Changelog:

[iOS][Changed] Refactor RCTEventEmitter initialization

Differential Revision: D40762253

cipolleschi avatar Oct 27 '22 15:10 cipolleschi

This pull request was exported from Phabricator. Differential Revision: D40762253

facebook-github-bot avatar Oct 27 '22 15:10 facebook-github-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,068,113 +0
android hermes armeabi-v7a 6,440,497 +0
android hermes x86 7,483,431 +0
android hermes x86_64 7,342,828 +0
android jsc arm64-v8a 8,933,067 +0
android jsc armeabi-v7a 7,667,418 +0
android jsc x86 8,993,443 +0
android jsc x86_64 9,472,201 +0

Base commit: dac6806559c49b267ce6eb2722c9ff3b9108ead1 Branch: main

analysis-bot avatar Oct 27 '22 15:10 analysis-bot

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: dac6806559c49b267ce6eb2722c9ff3b9108ead1 Branch: main

analysis-bot avatar Oct 27 '22 16:10 analysis-bot

PR build artifact for 674b2a20b02b054013e1deb033991cf989c80b96 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 27 '22 16:10 pull-bot

PR build artifact for 674b2a20b02b054013e1deb033991cf989c80b96 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 27 '22 16:10 pull-bot

This pull request was exported from Phabricator. Differential Revision: D40762253

facebook-github-bot avatar Nov 08 '22 11:11 facebook-github-bot

PR build artifact for 621cc6f352226fe9b9a89352c4579e5c76e28b64 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 08 '22 12:11 pull-bot

PR build artifact for 621cc6f352226fe9b9a89352c4579e5c76e28b64 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Nov 08 '22 12:11 pull-bot

This pull request was successfully merged by @cipolleschi in 25a00520d80b8b456b1eccfb106b75929f2f3bc2.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Nov 08 '22 15:11 react-native-bot