react-native icon indicating copy to clipboard operation
react-native copied to clipboard

refactor(rn tester app): change dimensions example to hooks

Open Marcoo09 opened this issue 3 years ago • 3 comments

Summary

This pull request migrates the dimensions example to using React Hooks.

Changelog

[General] [Changed] - RNTester: Migrate Dimensions to hooks

Test Plan

The animation works exactly as it did as when it was a class component

Marcoo09 avatar Oct 25 '22 20:10 Marcoo09

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ba5454c42134cc09772f024772b19a9990b1fb7f Branch: main

analysis-bot avatar Oct 25 '22 20:10 analysis-bot

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,065,869 +64,476
android hermes armeabi-v7a 6,469,952 +92,085
android hermes x86 7,377,547 -36,401
android hermes x86_64 7,348,549 +70,677
android jsc arm64-v8a 8,923,060 +55,495
android jsc armeabi-v7a 7,688,998 +83,116
android jsc x86 8,869,854 -55,611
android jsc x86_64 9,462,791 +54,090

Base commit: ba5454c42134cc09772f024772b19a9990b1fb7f Branch: main

analysis-bot avatar Oct 25 '22 21:10 analysis-bot

PR build artifact for 071127b213cffaacc0b1f95f072fa5d2b587c8d9 is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 25 '22 21:10 pull-bot

PR build artifact for 203e5e0d97fd73685974c7421cca9b04cb3f3a3c is ready. To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

pull-bot avatar Oct 27 '22 18:10 pull-bot

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Oct 27 '22 22:10 facebook-github-bot

This pull request was successfully merged by @Marcoo09 in 745e26288c656237b0f86f6cfc55643eeb0817ca.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Oct 31 '22 23:10 react-native-bot