react-native
react-native copied to clipboard
facebook
Add the `propConversion` header to generated props
Summary:
Generated props with custom structs generates implement their own version of fromRawProps in the header file, which has to invoke fromRawProps in the framework which is not available.
This Diff adds the missing header in the generated Props.h file and updates the tests.
This should also fix [this issue] https://github.com/facebook/react-native/issues/35054.
Changelog:
[General][Fixed] - Add missing header in the Codegen for props with object types.
Differential Revision: D40674432
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 7,062,075 | -8 |
| android | hermes | armeabi-v7a | 6,466,711 | +2 |
| android | hermes | x86 | 7,376,666 | -12 |
| android | hermes | x86_64 | 7,345,481 | +7 |
| android | jsc | arm64-v8a | 8,919,097 | -4 |
| android | jsc | armeabi-v7a | 7,685,595 | +9 |
| android | jsc | x86 | 8,868,792 | -13 |
| android | jsc | x86_64 | 9,459,530 | +6 |
Base commit: 5940d25cc184241ed77aca85c62f4ee071210d9b Branch: main
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: 5940d25cc184241ed77aca85c62f4ee071210d9b Branch: main
PR build artifact for a599afa109805b6eb76b7864db3c81e8327cb8b0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for a599afa109805b6eb76b7864db3c81e8327cb8b0 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.