react-native
react-native copied to clipboard
facebook
[Codegen]: Extract `getConfigType` function to `parsers/utils.js`
Summary
This PR is part of #34872.
This PR contains two changes, extracting the visitor object and then factoring out the getConfigType() function to the parsers/utils.js file. Then we can reuse the same function in both flow and typescript by passing the extracted visitor object.
Changelog
[Internal] [Changed] - Extract visitor object in the same file and factor out getConfigType() to parsers/utils.js.
Test Plan
Output of yarn jest react-native-codegen ensures all passed test cases
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| android | hermes | arm64-v8a | 7,754,795 | -2,079 |
| android | hermes | armeabi-v7a | 7,159,067 | -1,901 |
| android | hermes | x86 | 8,066,601 | -1,877 |
| android | hermes | x86_64 | 8,037,253 | -1,952 |
| android | jsc | arm64-v8a | 9,612,937 | -1,628 |
| android | jsc | armeabi-v7a | 8,379,072 | -1,463 |
| android | jsc | x86 | 9,559,947 | -1,444 |
| android | jsc | x86_64 | 10,152,843 | -1,512 |
Base commit: ff398e4e2632ece8a6f22d744e96e489ca3b9d92 Branch: main
| Platform | Engine | Arch | Size (bytes) | Diff |
|---|---|---|---|---|
| ios | - | universal | n/a | -- |
Base commit: ff398e4e2632ece8a6f22d744e96e489ca3b9d92 Branch: main
PR build artifact for 336265b09f4dad9ffe843cad2ebda735552550dc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 336265b09f4dad9ffe843cad2ebda735552550dc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 2f76ad4a080f277d96774e85a990caacd192caaa is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
PR build artifact for 2f76ad4a080f277d96774e85a990caacd192caaa is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.