react-native
react-native copied to clipboard
Fix windows warning/error over unsigned int
Summary
react-native-windows treats compiler c++ warning as errors, this is one of them. It fixes it by assigning i to unsigned instead of auto.
Changelog
[Internal] [Changed] - Fix react-native-windows compiler warning in AttributedString
Test Plan
code is already merged into react-native-windows and passing all tests. The for loop changed is also used directly above in AttributedString::compareTextAttributesWithoutFrame
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Hi @TatianaKapos, thanks for opening this. Can I ask you to log into https://app.circleci.com and then to rebase the PR on main? This should restart the OSS Pipeline which failed due to some problem with the OAuth token.
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
android | hermes | arm64-v8a | 7,755,804 | +9 |
android | hermes | armeabi-v7a | 7,159,876 | -8 |
android | hermes | x86 | 8,067,410 | +7 |
android | hermes | x86_64 | 8,038,084 | -42 |
android | jsc | arm64-v8a | 9,614,020 | +24 |
android | jsc | armeabi-v7a | 8,379,963 | -8 |
android | jsc | x86 | 9,560,826 | +6 |
android | jsc | x86_64 | 10,153,749 | -38 |
Base commit: 9e68eea2c872fa0cef30303f31a2bce996997e88 Branch: main
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Platform | Engine | Arch | Size (bytes) | Diff |
---|---|---|---|---|
ios | - | universal | n/a | -- |
Base commit: 9e68eea2c872fa0cef30303f31a2bce996997e88 Branch: main
PR build artifact for f117fc2986c5ad272f4a1ad4c1a5fc7b98c9e80c is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball>
in your React Native project.
This pull request was successfully merged by @TatianaKapos in 950ea915bee6b3b30107c04bd34990fb390c7268.
When will my fix make it into a release? | Upcoming Releases