react-native icon indicating copy to clipboard operation
react-native copied to clipboard

feat: Add tabIndex prop to View component

Open gabrieldonadel opened this issue 1 year ago • 5 comments

Summary

This adds the tabIndex Android only prop to View as requested on https://github.com/facebook/react-native/issues/34424 mapping the existing focusable prop to tabIndex so that tabIndex={0} maps to focusable={true} and tabIndex={-1} represents focusable={false}.

Changelog

[Android] [Added] - Add tabIndex prop to View component

Test Plan

I'm still investigating the best way to test this but we're are just mapping this to an existing prop

gabrieldonadel avatar Aug 23 '22 19:08 gabrieldonadel

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,617,967 +95
android hermes armeabi-v7a 7,032,206 +87
android hermes x86 7,918,045 +114
android hermes x86_64 7,891,666 +118
android jsc arm64-v8a 9,495,266 -17
android jsc armeabi-v7a 8,272,879 -35
android jsc x86 9,433,068 -6
android jsc x86_64 10,026,062 -2

Base commit: ed21a3e20fcbba131792f469fe004f8cf97a4018 Branch: main

analysis-bot avatar Aug 23 '22 19:08 analysis-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 23 '22 21:08 facebook-github-bot

@necolas I've just rebased it now that CI has been fixed

gabrieldonadel avatar Aug 24 '22 18:08 gabrieldonadel

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: ed21a3e20fcbba131792f469fe004f8cf97a4018 Branch: main

analysis-bot avatar Aug 24 '22 18:08 analysis-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 26 '22 19:08 facebook-github-bot

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 29 '22 17:08 facebook-github-bot

This pull request was successfully merged by @gabrieldonadel in 621f4cf3b12979b62d2e1d49d63eaf85e0707026.

When will my fix make it into a release? | Upcoming Releases

react-native-bot avatar Aug 30 '22 02:08 react-native-bot