react-native icon indicating copy to clipboard operation
react-native copied to clipboard

[Releases] Add path-specified filters to `rn-changelog-generator`

Open lunaleaps opened this issue 3 years ago • 3 comments

Filter out commits that touch certain "internal" files.

We currently use the rn-changelog-generator to generate our React Native release changelog: https://github.com/facebook/react-native/blob/main/CHANGELOG.md

The release process involves sanitizing the changelog before release. There's usually a lot of noise (ie. commits that only touch RNTester) that we could provide some rules to filter out of the generated changelog.

This issue is about adding generic filters (first use-case could be path-based) to this script. Code lives here: https://github.com/microsoft/rnx-kit/tree/main/packages/rn-changelog-generator

lunaleaps avatar Feb 01 '22 01:02 lunaleaps

Hi, quick question regarding what you meant by adding generic filters, would this be adding a --exclude flag that filters out files that match a specific pattern, or would this be adding hardcoded paths to the rn-changelog-generator repo?

gabrieldonadel avatar Feb 16 '22 01:02 gabrieldonadel

Hmm I originally was thinking hardcoding paths -- it'll probably have to be that every path in the commit is under the filter for us to filter it out of the changelog

lunaleaps avatar Feb 16 '22 18:02 lunaleaps

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Aug 26 '22 02:08 github-actions[bot]

Closing this issue for now since it's not a priority

lunaleaps avatar Aug 29 '22 17:08 lunaleaps