react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

Update linking.md (remove override keyword that make build fail in last RN version)

Open LaGregance opened this issue 4 months ago • 5 comments

Remove "override" keyword as AppDelegate inherit directly from UIApplicationDelegate that is a protocol, using override cause error "Method does not override any method from its superclass".

LaGregance avatar Jul 29 '25 13:07 LaGregance

Hi @LaGregance!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jul 29 '25 13:07 facebook-github-bot

Deploy Preview for react-native ready!

Name Link
Latest commit e41a93ad2d95d8dd9ea43587710d1a354d0bf8e5
Latest deploy log https://app.netlify.com/projects/react-native/deploys/6888cdfc6779fe000726e966
Deploy Preview https://deploy-preview-4684--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jul 29 '25 13:07 netlify[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 29 '25 15:07 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jul 29 '25 15:07 facebook-github-bot

hey @LaGregance 👋 do you know who should we tag to get this merged?

ignaciosantise avatar Oct 09 '25 20:10 ignaciosantise