react-native-website
react-native-website copied to clipboard
facebook
Update introduction.md to fix visibility on iOS snack player.
Adding set background color to the style so that the code is visible on iOS snack player.
Hi @Jack-Jackk!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | 9d6cdb7e803d55ee717fb12d16f8b489b105c215 |
| Latest deploy log | https://app.netlify.com/projects/react-native/deploys/68484c1d48007300075e1832 |
| Deploy Preview | https://deploy-preview-4640--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hey @Jack-Jackk, thanks for spotting that issue! 👍
I think that we should approach this a bit differently, by decoupling Snack component theme parameter, from Appetize device appearance preference in the Snack code, and then use the new param on some of the examples (simple ones) to set preview device theme to "light", no matter of website theme selected by the user.
We have address that on the Snack embed code side (see the referenced PR), and all examples will load by default in light mode, which should address this issue globally, closing this one as done.