react-native-website
react-native-website copied to clipboard
facebook
Update backhandler.md (remove removeEventListener from docs)
BackHandler.removeEventListener got removed in react-native 0.77. This PR removes removeEventListener from BackHandler docs
Hi @MaksymAleieiv!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | 672254b9441aa1f2208b35847ce3ec8bc2eec1a5 |
| Latest deploy log | https://app.netlify.com/sites/react-native/deploys/67a09457074e7a000822ab45 |
| Deploy Preview | https://deploy-preview-4473--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hey @MaksymAleieiv, thanks for the contribution!
Can you also apply the changes to unversioned docs (in docs directory) and to all newer versioned docs than 0.77?
Refs:
- https://github.com/facebook/react-native/commit/44d619414c1de3dbf17a421afa8dbcec7cdab025
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | 50bbc7fe6c6a998942b4ecd727abe41a76f4e704 |
| Latest deploy log | https://app.netlify.com/projects/react-native/deploys/68eacbfe28490f000886d70c |
| Deploy Preview | https://deploy-preview-4473--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify project configuration.
Looks like after the branch rebase with current main there are no changes to merge. After looking at changes history, found that removeEventListener has been removed in the following PR:
- https://github.com/facebook/react-native-website/pull/4475
Closing this one, as no longer needed.