react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

Update image.md fresco GIF library version

Open coderBeat opened this issue 1 year ago • 4 comments

with react-native 0.75, this library doesn't work:

  // For animated GIF support
  implementation 'com.facebook.fresco:animated-gif:3.1.3'

We need to switch to the latest library:

    // For animated GIF support
    implementation 'com.facebook.fresco:animated-gif:3.2.0'

coderBeat avatar Aug 21 '24 12:08 coderBeat

Hi @coderBeat!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 21 '24 12:08 facebook-github-bot

Deploy Preview for react-native ready!

Name Link
Latest commit 3adf34babda48e2400f7570537feb2401ccb4369
Latest deploy log https://app.netlify.com/sites/react-native/deploys/66c5dd127521920008377e01
Deploy Preview https://deploy-preview-4196--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Aug 21 '24 12:08 netlify[bot]

I thought about that, but I only tested the GIF support, I don't have any idea about the rest.

coderBeat avatar Aug 22 '24 07:08 coderBeat

I thought about that, but I only tested the GIF support, I don't have any idea about the rest.

They do update in a lockstep so I'd rather keep them aligned rather than recommending mixed version of Fresco

cortinico avatar Aug 22 '24 10:08 cortinico

Duplicate of https://github.com/facebook/react-native-website/pull/4359

javache avatar Nov 20 '24 21:11 javache