react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

docs: remove outdated tv docs

Open moskalakamil opened this issue 1 year ago β€’ 12 comments

Since React Native for TV has been moved to a separate repository, information on how to develop for this library should not be included in the main React Native documentation. We should either remove this section entirely or add a link redirecting users to the react-native-tvos Wiki.

moskalakamil avatar Jul 04 '24 20:07 moskalakamil

Deploy Preview for react-native ready!

Name Link
Latest commit 3bdbb8a22c5673963c29ff70d9dc951e933c0f71
Latest deploy log https://app.netlify.com/sites/react-native/deploys/668706b9369aa70008010d22
Deploy Preview https://deploy-preview-4155--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 04 '24 20:07 netlify[bot]

Deploy Preview for react-native ready!

Name Link
Latest commit 6b4b0d767e1639e30625d2a785e6ef65c7b368cd
Latest deploy log https://app.netlify.com/sites/react-native/deploys/6708071736c412000962098e
Deploy Preview https://deploy-preview-4155--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jul 04 '24 20:07 netlify[bot]

@Simek any thoughts on this one?

cortinico avatar Jul 05 '24 14:07 cortinico

Let's make sure that @douglowder is fine with that change, and if wiki is a right place to redirect people.

Simek avatar Jul 05 '24 14:07 Simek

@Simek the official react-native-tvos documentation links to their wiki, thats why I decided to add this link

moskalakamil avatar Jul 05 '24 14:07 moskalakamil

I have in mind that we might want to split up the redirected group, between those, who use frameworks and those who are not, like we do in new setup environment sections.

For example, for Expo users, we got a dedicated guide on how to build TV apps - https://docs.expo.dev/guides/building-for-tv/ - which is also referenced in the wiki links, and that way we might spare user a link jump.

Also, RN TV wiki seems to contains only one doc page, and rest are an external links do different resources, so it might be more valuable to link people into the doc file directly, which will guide them through the setup.

Simek avatar Jul 05 '24 14:07 Simek

@Simek Sure, provide me please information on which of these two options we prefer. I would also like to note that if we redirect to TV Wiki, we won't have to worry about updating this subpage in the future, as all TV-related information will be then updated by the react-native-tvos community in their repo

moskalakamil avatar Jul 05 '24 17:07 moskalakamil

@douglowder done ;)) Should i update earlier docs versions?

moskalakamil avatar Jul 05 '24 20:07 moskalakamil

done ;)) Should i update earlier docs versions?

@moskalakamil yes thanks, just the versions that Meta currently supports (I think that is 0.71 and up)

douglowder avatar Jul 05 '24 20:07 douglowder

@douglowder finished, thanks for guidance!

moskalakamil avatar Jul 05 '24 20:07 moskalakamil

@moskalakamil no problem! I approve the request, although I don't have access to do that in GitHub πŸ˜„

douglowder avatar Jul 05 '24 20:07 douglowder

@Simek updated πŸ‘

moskalakamil avatar Jul 08 '24 11:07 moskalakamil

Hey @Simek, just following up on my PR β€” it’s been sitting for a while. Thanks!

moskalakamil avatar Oct 10 '24 12:10 moskalakamil

Oh, sorry for missing that one, and thanks for the ping! πŸ™

One last thing before shipping, can we also update the file for 0.75 release, so we got a full coverage?

  • https://github.com/facebook/react-native-website/blob/main/website/versioned_docs/version-0.75/building-for-tv.md

Simek avatar Oct 10 '24 13:10 Simek

Sure! I’ve done this @Simek

moskalakamil avatar Oct 10 '24 17:10 moskalakamil