react-native-website
react-native-website copied to clipboard
facebook
Update intro-react.md
Hi @CoryHrycko!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | 738870a40ba25b2769d6563a453505fbaa1f0861 |
| Latest deploy log | https://app.netlify.com/sites/react-native/deploys/66577a152054b30008b3a383 |
| Deploy Preview | https://deploy-preview-4083--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
this might be a misconfiguration on my end, but isn't it still necessary for TypeScript users?
@Rexogamer, it shouldn't be needed. I use Typescript daily, and since React Native version 0.64, React Version 17, and I believe Typescript 4.1 we hadn't have to import that specific part. The current Typescript, version 5.4, playgrounds do not include these imports. For new projects this is not needed, unless the party needs to update global dependencies. Typescript is also separate from React, which both of us know, none the less I would update the linter dependencies in your project, and that should resolve any formatting issues. If you have some specific questions I will help.
you'll also want to update docs/intro-react.md (the unversioned article) - other than that, this looks good to me :3
you'll also want to update
docs/intro-react.md(the unversioned article) - other than that, this looks good to me :3
Added, Thank you for the thorough review! As I read through you may see me again. 😄