react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

InteractionManager.runAfterInteractions() is not working properly on web?

Open artus9033 opened this issue 1 year ago • 1 comments

Description

InteractionManager documentation states the following:

Note: InteractionManager.runAfterInteractions() is not working properly on web. It triggers immediately without waiting until the interaction is finished.

Which is most likely outdated.

What is the problem?

The docs [here] state that InteractionManager.runAfterInteractions() is not working properly on the web. However, this issue resulted in a PR being introduced and merged. The code introduced in this PR seems to be present at the moment, e.g. here. Based on a practical test I performed, it indeed seems that this PR is present in the current version of react-native-web and works properly, since the task queue for InteractionManager has been implemented and performs as intended.

How can we address it?

Verify this proposal and update the documentation by stating that this invalid behaviour applies to react-native-web versions below 0.19.

Why is it important?

It may cause confusion.

Who needs this?

Every user reading the documentation.

When should this happen (use version numbers if needed)?

N/A

artus9033 avatar Nov 16 '23 13:11 artus9033

I recall encountering a pull request for InteractionManager a while ago, specifically around the time when Rachel initiated the Component Docs Drive. In that PR, the example code specifically configured the supportedPlatforms for snack to only include iOS and Android. This exclusion of the web platform was intentional, stemming from the issues with InteractionManager.runAfterInteractions() not functioning correctly on web platforms.

In my view, documentation specifically addressing InteractionManager for react-native-web should be included in the react-native-web documentation, rather than the main react-native documentation. This distinction is important for clarity and accuracy.

Interestingly, this issue has been resolved in react-native-web. Therefore, I suggest removing the previous notes regarding this issue from the documentation. This update won't be detrimental in any way; in fact, it will help avoid potential confusion for users.

@lunaleaps, I would like to get your opinion on this matter. Apologies for the direct mention, but I thought it was pertinent to involve you in this discussion

gedeagas avatar Dec 16 '23 18:12 gedeagas

👋 Hey there, it looks like there has been no activity on this issue in the last 90 days. Has the issue been fixed, or does it still require the community attention? This issue will be closed in the next 7 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Mar 16 '24 01:03 github-actions[bot]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

github-actions[bot] avatar Mar 23 '24 01:03 github-actions[bot]