react-native-website
react-native-website copied to clipboard
facebook
settings doc upgrade issue #3637
Hi @pedropbazzo!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | 9e11ec06d1230f9de8e2f2a7e6b7b0313ce0b1db |
| Latest deploy log | https://app.netlify.com/sites/react-native/deploys/64ea23dff7d2710007079883 |
| Deploy Preview | https://deploy-preview-3835--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
In my opinion this does not clear up the confusion on why the property would be null.
The text added by this PR is just a different way of saying index is optional. The docs already mention it can be optional so the change does not add more value over what is already there.
It should be cleared up and explained in what situation the index property would be null.
