react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

Ambiguity on why the index property in ViewToken is marked optional

Open jobpaardekooper opened this issue 1 year ago • 4 comments

Description

On the ViewToken page in the docs it shows that the index property is optional. This is not explained in any further detail by the docs.

What is the problem?

It is unclear to me in what situation this property would be null. This object is used as a parameter for the onViewableItemsChanged callback in VirtualizedList so it is in turn also used in both FlatList and SectionList. This makes me think there wouldn't be a situation where index would be null.

How can we address it?

Update the description of the index property on ViewToken to clarify in what situation it could be null.

If anyone knows a resource like an issue in the react-native repo or a from post that discusses this or can explain it to me I can also make a PR to clarify the description on the property.

Why is it important?

It is currently ambiguous why the index property on ViewToken is marked as optional.

Who needs this?

Anyone using the onViewableItemsChanged prop and relies on the indexes of the callback.

jobpaardekooper avatar Mar 22 '23 19:03 jobpaardekooper

👋 Hey there, it looks like there has been no activity on this issue in the last 90 days. Has the issue been fixed, or does it still require the community attention? This issue will be closed in the next 7 days if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 21 '23 01:06 github-actions[bot]

No response yet so it would not consider this "fixed". (Just commenting so the issue will stay open, as it should)

jobpaardekooper avatar Jun 21 '23 10:06 jobpaardekooper

https://github.com/facebook/react-native-website/pull/3835 @jobpaardekooper

pedropbazzo avatar Aug 26 '23 16:08 pedropbazzo

@pedropbazzo please see my comment on your PR. I don't think it solves this issue.

jobpaardekooper avatar Aug 26 '23 16:08 jobpaardekooper