react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

Update to Docusaurus stable release, fix alert admonition styling

Open Simek opened this issue 3 years ago • 3 comments

Why & How

This PR updates the Docusuaurs to the latest and stable release! 🎉

There is no changelog published yet from latest RC, but there were almost no changes between those versions.

Testing the bump locally I was not bale to spot any visual regressions.

I have also utilize this bump to address the warning admonitions style, which since bump to RC started to match again against one of our legacy CSS selectors, which lead to unexpected effect (text centered, small font), those issue have been fixes as well as double underline for links in admonitions.

Preview

Screenshot 2022-08-08 140012

Simek avatar Aug 08 '22 12:08 Simek

Deploy Preview for react-native ready!

Name Link
Latest commit 80becf25bee29f13b0dc7132d1c94fa4bdb59fcf
Latest deploy log https://app.netlify.com/sites/react-native/deploys/62f928c6341b47000841a847
Deploy Preview https://deploy-preview-3248--react-native.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 08 '22 12:08 netlify[bot]

I've accidentally approved this one without checking the live preview. I'm handing over the @huntie for a full-review

cortinico avatar Aug 08 '22 15:08 cortinico

Thank you for the review and catching those issues! 🙏 Will address therm soon.

Generally our styles are messy because they came with us a long way, through alphas and betas, and parts dates even back to v1. Ideally we should rewrite them all to be honest at same point. 🙂

Those top banners are something legacy, that we additionally customized before the Swizzling was an option. We probably should just replace them with admonitions or custom components.

Simek avatar Aug 08 '22 15:08 Simek