react-native-website
react-native-website copied to clipboard
facebook
Updated button.md to reference Pressable instead of Touchable Opacity…
Updated button.md to reference Pressable instead of Touchable Opacity and TouchableWithoutFeedback
Hi @athakur3!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Hi @athakur3!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with
CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Signed!
Deploy Preview for react-native ready!
| Name | Link |
|---|---|
| Latest commit | b60270fa068471097096acf4253f2539a5c32a5b |
| Latest deploy log | https://app.netlify.com/sites/react-native/deploys/62e928f28408160009bfd37d |
| Deploy Preview | https://deploy-preview-3237--react-native.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
looks good @athakur3, just curious why recommend the new Pressable over TouchableOpacity or TouchableWithoutFeedback?
since TouchableOpacity or TouchableWithoutFeedback remain a simpler start where we recommend Pressable for a more extensive approach
looks good @athakur3, just curious why recommend the new Pressable over TouchableOpacity or TouchableWithoutFeedback?
since TouchableOpacity or TouchableWithoutFeedback remain a simpler start where we recommend Pressable for a more extensive approach
@leotm You're right in saying that it's more extensive. But, going with the "future-proof" reference, I assume that we are eventually going to migrate to Pressable API. Hence this. Let me know if I'm wrong in my assumption.
gotcha ^ makes sense if that implies we're going to deprecate both, SWIM (Someone Who Isn't Me) will know
