react-native-website icon indicating copy to clipboard operation
react-native-website copied to clipboard

doc: add a note on the implementation detail

Open trajano opened this issue 2 years ago • 3 comments

Added a note in case people would think that the Button would behave 100% like a native control, but find out it is simply a stylized Touchable https://github.com/facebook/react-native/blob/ef6ad1f2d65639a1d41e05a895ad21ce97192749/Libraries/Components/Button.js#L342-L351

I didn't add the link to the specific source lines as I thought that would be TIM.

trajano avatar Sep 11 '21 15:09 trajano

Hi @trajano!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Sep 11 '21 15:09 facebook-github-bot

✔️ Deploy Preview for react-native ready!

🔨 Explore the source changes: 18c0ae0a9ed4b4998570a6d38d79aa47fb09cbd5

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/613ccc3b902fc10007be6d2b

😎 Browse the preview: https://deploy-preview-2779--react-native.netlify.app

netlify[bot] avatar Sep 11 '21 15:09 netlify[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Sep 11 '21 16:09 facebook-github-bot