react-native-website
react-native-website copied to clipboard
The intent of StyleSheet.create
It is not clear why StyleSheet.create would be required when a plain object could be used in its place. I have referred this https://stackoverflow.com/questions/38886020/what-is-the-point-of-stylesheet-create to add some details.
Hi @puranik3!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Deploy Preview for react-native ready!
Built with commit aef876a5856964917212acb55f888f1e8146f91a
https://deploy-preview-2625--react-native.netlify.app
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
We don't currently do the optimization where styles become an ID, but this pattern lets us make that optimization in the future.
Also, for things like react-native-web, this pattern is used to create actual style sheets.
@puranik3 Can you update the added note according to the Eli's comment? 🙂