Automatically include `.gitignore` in `project_excludes`
We want to be able to include .gitignore globs in project_excludes by default to reduce the amount of manual configuration that needs to be done.
Right now, we have some basic, hard-coded defaults to ignore certain files/patterns we notice aren't useful to search for type checking. We should expand this behavior to include everything we can find in a .gitignore.
This will likely involve three steps:
- Performing an upward search for a
.gitignorefile - Parsing the results of the
.gitignorefile and turning them into twoGlobs, one for includes and another for excludes - Wiring it into the config, most likely in
Config::configure()
i'm a new contributor, and want to work on this. Do i need to assign myself or just start?
@BaoNguyen09 I can assign you, go ahead and start, and let us know if you have any questions
Thanks!
Hey @BaoNguyen09, thanks for picking this up! Please let me know if you have any questions with this, and feel free to join our Discord server for quicker feedback (you can DM me directly if you need).
For sure, i'm setting up the project and will ask you as soon as i need anything. Thank you for the support!
Hey @BaoNguyen09, just wanted to check in and see how it's going. Have you been able to take a look yet? Don't forget that we're here if you have any questions about getting it set up/implementation approaches/....
yeah i'm working on it right now, last week was busy but i finished setting up and understanding the issue now
Awesome, thanks for the update @BaoNguyen09!
I was working on a similar bug with globbing, and found this spot where it actually might be better to wire it in compared to Config::configure(), since it will be easier for us to access in our main.rs entrypoint.
Hope this helps!
@BaoNguyen09 and I spoke async, and decided to put it back out for anyone to pick up if they're interested.
Hey, I'm a newcomer and would totally love to help. Could you assign me on this?
Hey @johernandezvaz, sure! Let us know if you need pointers.
Hey @johernandezvaz, sure! Let us know if you need pointers.
Yeah, I actually do believe I've got to make a pull request for this, I already forked it, just looking into how it's best to work on this
This issue has someone assigned, but has not had recent activity for more than 2 weeks.
If you are still working on this issue, please add a comment so everyone knows. Otherwise, please unassign yourself and allow someone else to take over.
Thank you for your contributions!
Putting this back up for grabs
I think I'm just going to take this so that I can get it done soon.
This issue has someone assigned, but has not had recent activity for more than 2 weeks.
If you are still working on this issue, please add a comment so everyone knows. Otherwise, please unassign yourself and allow someone else to take over.
Thank you for your contributions!
Completed with the diffs landed with #862