pyre-check icon indicating copy to clipboard operation
pyre-check copied to clipboard

Make pyre able to read configuration from `pyproject.toml`

Open WangGithubUser opened this issue 2 years ago • 2 comments

Pre-submission checklist

  • [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • [x] pre-commit run

Summary

This PR resolves #695. I'm not sure we should look for pyproject.toml silently when .pyre_configuration is not valid, or only look for it when a flag provided.But, I prefer the first resoulution because the second need to provide a flag in all runs.However, I want to hear you opinion.

Test Plan

Look for if the unittest passed. As the unittest is not avalible this time(see footnote), I ran test in my local machine with python3.10: image

Footnote:

  • GitHub Action workflow Test fails due to match statement is incompatible with Python3.8 and 3.9, and is not related to this PR.To make this easier to review and avoid confliting, I will rebase this PR on the top of main if the match statement refactored with if-elif-else statement but not do it in this PR.
  • As a post-process, we need to delete unneeded .pyre_configuration at the root of this project after the nightly version of Pyre with this diff deployed.I intergrated configurations into pyproject.toml.

WangGithubUser avatar Sep 29 '23 05:09 WangGithubUser

Is this still a Draft PR?

cclauss avatar Apr 02 '24 09:04 cclauss

@WangGithubUser @cclauss Is this still active? Would love to see this feature.

hparente1313 avatar Apr 03 '24 23:04 hparente1313