pyre-check
pyre-check copied to clipboard
Make pyre able to read configuration from `pyproject.toml`
Pre-submission checklist
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running
pip install -r requirements-dev.txt && pre-commit install - [x]
pre-commit run
Summary
This PR resolves #695.
I'm not sure we should look for pyproject.toml silently when .pyre_configuration is not valid, or only look for it when a flag provided.But, I prefer the first resoulution because the second need to provide a flag in all runs.However, I want to hear you opinion.
Test Plan
Look for if the unittest passed.
As the unittest is not avalible this time(see footnote), I ran test in my local machine with python3.10:
Footnote:
- GitHub Action workflow
Testfails due tomatchstatement is incompatible with Python3.8 and 3.9, and is not related to this PR.To make this easier to review and avoid confliting, I will rebase this PR on the top of main if thematchstatement refactored withif-elif-elsestatement but not do it in this PR. - As a post-process, we need to delete unneeded
.pyre_configurationat the root of this project after the nightly version of Pyre with this diff deployed.I intergrated configurations intopyproject.toml.
Is this still a Draft PR?
@WangGithubUser @cclauss Is this still active? Would love to see this feature.