pyre-check icon indicating copy to clipboard operation
pyre-check copied to clipboard

Add result cards to pysa playground

Open arpancodes opened this issue 4 years ago • 3 comments

Pre-submission checklist

  • [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
    • [x] pre-commit run

Summary

This PR formats the results in different cards, rather than beings displayed like a single paragraph.

Test Plan

Screenshot 2021-12-09 at 9 50 43 PM

arpancodes avatar Dec 09 '21 16:12 arpancodes

@0xedward has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Dec 09 '21 20:12 facebook-github-bot

@arpancodes has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar Dec 09 '21 21:12 facebook-github-bot

@0xedward has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot avatar Dec 09 '21 21:12 facebook-github-bot

Hey @arpancodes, it's been a while. If you would still want to merge this, can I ask you to rebase this PR on top of master? Thanks.

arthaud avatar Aug 31 '23 10:08 arthaud

closing due to inactivity. feel free to open another if these changes are still requested

kinto0 avatar Sep 13 '23 17:09 kinto0