Proxy Authentication

Open SteveSelva opened this issue 1 year ago • 3 comments

When the HTTP1xCodec generates HTTP CONNECT request and waits for a response.

And when it receives status code as 200, there should not be any body according to the protocol and its working fine.

But when the server responds with 407 Proxy Authentication Required, it may send a body with it. In this case, the codec is failing and throwing an error.

Instead of directly denying the body for HTTP CONNECT request, it can be done relative to the status code from response.

Can you modify the codec accordingly.

Nov 07 '24 11:11 SteveSelva

Would you like to put up a PR we can review? It might take some time before we can work on this modification.

Nov 07 '24 14:11 afrind

Yeah sure, let me raise a PR.

Nov 07 '24 15:11 SteveSelva

Raised a PR : https://github.com/facebook/proxygen/pull/532

Kindly review it.

Nov 07 '24 16:11 SteveSelva