proxygen
proxygen copied to clipboard
Add vcpkg installation instructions
proxygen is available as a port in vcpkg, a C++ library manager that simplifies installation for proxygen and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build proxygen, ready to be included in their projects.
We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64, UWP, ARM) to keep a wide coverage for users.
I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library.
Hi JackBoosY! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
@JackBoosY thank you so much for doing this!
I have a couple questions before merging. 1.a. Is there any automation that could help us keep the package up to date with the latest master here on github ? 1.b. We can build for windows here using Github Actions but there are a few minor incompatibilities that we will need to address 2. so, did you have to apply any other patch on top of https://github.com/microsoft/vcpkg/blob/master/ports/proxygen/fix-tools-path.patch ? 3. in general we refrain from building packages since we provide no API guarantee and we usually ask folks to just always use master. I'd like to maybe add a few lines on that. But this is going to be less important if we find a way to fix 1 above
thanks again for your contribution!
Hi @lnicco, thanks for your response.
-
1.a. We do have a command option
--head
to build the latest version, but since we need to adapt vcpkg, this may fail to build. I will explain below. We update every port regularly, and we prefer to use the release version over the development version. We try our best to ensure the correctness of each port update, and will also fix usage issues. -
1.b. Because vcpkg specifies the storage location of the generated files, and the current triplet settings (such as library linkage, CRT linkage) must be adapted for each triplet, and the dependencies in it must be changed to the ports in vcpkg, so we must make some change.
-
2.. We very much hope that the official staff can help us maintain the port on vcpkg to reduce problems during build / use.
Thanks.
Any response here?
@afrind has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@afrind merged this pull request in facebook/proxygen@815bdf381042b9f716c1fd0de96c902c439a77e2.