Build broken in master

[sgiannoulis]

Issue Description

Build script fails in building fb303

Environment

Ubuntu 18.04 master branch (e7ecdf2ae58b565011929283164734ea72649c0f)

Minimal test code / Steps to reproduce the issue

run the build_openr.sh script

What's the actual result?

[1/6] Building CXX object CMakeFiles/fb303.dir/fb303/detail/QuantileStatWrappers.cpp.o FAILED: CMakeFiles/fb303.dir/fb303/detail/QuantileStatWrappers.cpp.o /usr/bin/c++ -DFMT_LOCALE -DGFLAGS_IS_A_DLL=0 -I/tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git -I. -isystem /opt/facebook/gflags-JqRuzNt9wrd66svP-JwHooXjNpWv4s_5pOq5ghh6xkE/include -isystem /opt/facebook/glog-d463DCaqQAHuVnj4iWlVfBDUVSH3hmbQq6x_RXkGnQM/include -isystem /opt/facebook/double-conversion-Ym_-SRYWlLfrJPdbuyCIMG8MTkLUJM7oW8oLmxkOT5k/include -isystem /opt/facebook/zstd-SLWGIJew-gneFBHMsG7xjk476U4z-N5xrexNO4kL6-Q/include -isystem /usr/include/libiberty -isystem /opt/facebook/folly/include -isystem /opt/facebook/fmt-JZzS5tZkGFJ2sEVTyQrbqr93ehHdTXGzR1Nla2EF3GE/include -isystem /opt/facebook/fbthrift/include -isystem /opt/facebook/wangle/include -isystem /opt/facebook/fizz/include -O2 -g -DNDEBUG -fPIC -std=c++1z -MD -MT CMakeFiles/fb303.dir/fb303/detail/QuantileStatWrappers.cpp.o -MF CMakeFiles/fb303.dir/fb303/detail/QuantileStatWrappers.cpp.o.d -o CMakeFiles/fb303.dir/fb303/detail/QuantileStatWrappers.cpp.o -c /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers.cpp In file included from /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers.h:109:0, from /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers.cpp:18: /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h: In member function ‘void facebook::fb303::detail::DynamicQuantileStatWrapper<N>::addValue(double, std::chrono::V2::steady_clock::time_point, Args&& ...)’: /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:60:37: error: ‘make_hazard_pointer’ is not a member of ‘folly’ folly::hazptr_holder<> h = folly::make_hazard_pointer<>(); ^~~~~~~~~~~~~~~~~~~ /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:60:57: error: expected primary-expression before ‘>’ token folly::hazptr_holder<> h = folly::make_hazard_pointer<>(); ^ /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:60:59: error: expected primary-expression before ‘)’ token folly::hazptr_holder<> h = folly::make_hazard_pointer<>(); ^ /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:61:19: error: ‘class folly::hazptr_holder<>’ has no member named ‘protect’ auto mapPtr = h.protect(stats); ^~~~~~~ /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:78:16: error: ‘class folly::hazptr_holder<>’ has no member named ‘protect’ mapPtr = h.protect(stats_); ^~~~~~~ /tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/repos/github.com-facebookincubator-fb303.git/fb303/detail/QuantileStatWrappers-inl.h:83:5: error: ‘class folly::hazptr_holder<>’ has no member named ‘reset_protection’; did you mean ‘get_protected’? h.reset_protection(); ^~~~~~~~~~~~~~~~ get_protected [3/6] Building CXX object fb303/thrift/CMakeFiles/fb303_thrift_cpp.dir/gen-cpp2/BaseService_processmap_compact.cpp.o ninja: build stopped: subcommand failed. Command '['/opt/facebook/cmake-K2KXPxUQLicaKkTimk4VIgFrxNloUoRcweVRlJCBQRw/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZusersZsgiannouZopenrZbuildZfbcode_builder-root/build/fb303', '--target', 'install', '--config', 'Release', '-j', '8']' returned non-zero exit status 1. !! Failed [ERROR]: Failed to build openr

What's the expected result?

Finalize build and have openr operational.

[cooperlees]

Thanks for reporting. I know we really need to get our CI passing again + high signal. It seems here we have a dependency out of date on their repo. We're chasing this up internally to see why this is the case.

[cooperlees]

So the build seems to build for me in Docker. Just thrift errors when trying to build the breeze cli's thrift 'py3' extensions now fail due to a missing thrift file for a feature that's not Open Sourcable.

Step 11/15 : RUN cd /src && build/build_breeze.sh
 ---> Running in 7e9e3e768132
[FAILURE:openr-thrift/openr/if/OpenrConfig.thrift:16] Could not find include file configerator/structs/neteng/config/vip_service_config.thrift
Traceback (most recent call last):
  File "/src/build/gen.py", line 65, in <module>
    generate_thrift_files()
  File "/src/build/gen.py", line 47, in generate_thrift_files
    check_call(
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/opt/facebook/fbthrift/bin/thrift1', '--gen', 'mstch_cpp2', '-I', 'openr-thrift', '-I', 'fb303-thrift', '-I', 'fbzmq-thrift', '-I', 'neteng-thrift', '-I', 'fbthrift-thrift', '-I', '.', '-o', 'openr-thrift/openr/if', 'openr-thrift/openr/if/OpenrConfig.thrift']' returned non-zero exit status 1.
build/build_breeze.sh: line 62: /src/fbthrift-thrift/gen-cpp2/metadata_metadata.h: No such file or directory
build/build_breeze.sh: line 63: /src/fbthrift-thrift/gen-cpp2/metadata_types.h: No such file or directory
build/build_breeze.sh: line 64: /src/fbthrift-thrift/gen-cpp2/metadata_types_custom_protocol.h: No such file or directory

Will try find some time to work this out ...