openbmc icon indicating copy to clipboard operation
openbmc copied to clipboard

[Delta] aspeed: gpio: Add ast2600 gpio table.

Open ChuTingI opened this issue 1 year ago • 2 comments

Hi all,

I noticed that you don't have an ast2600 GPIO table, so I added ast2600-gpio.csv according to ASPEED ast2620 datasheet and converted it to ast2600_gpio_table.py by the parser you provided. Also, I changed the value of SCU_REG_MAX from 0x1A4 to 0x6E8 to fix the issue of parsing error while booting. Last, I added ast2600_gpio_table.py in openbmc-gpio_0.2.bbappend and built it successfully. This commit can be built and booted successfully. All changes are under the meta-aspeed directory.

Thanks, Delta

ChuTingI avatar Dec 06 '22 03:12 ChuTingI

Hi @ChuTingI!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 06 '22 03:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 06 '22 22:12 facebook-github-bot