Update all .buckconfig/.gitignore/.watchmanconfig/buck.iml/.pyre_config to ignore .pylsp related folders

Open inseokhwang opened this issue 2 years ago • 4 comments

Summary: We're updating PYLS and Pyre to use .pylsp as isolation-prefix: D46599960, D46602539.

We'd like to add these .pylsp to ignore folders to prevent users from having bunch of generated files listed in ISL.

I went through every ".lsp-buck-out" and looked for references of .lsp and added new entries with .pylsp where necessary. There are few code mentions of .lsp-buck that seems relevant that I'll send out another diff for so that I can add the project owners.

Differential Revision: D46668238

Jun 13 '23 21:06 inseokhwang

This pull request was exported from Phabricator. Differential Revision: D46668238

Jun 13 '23 21:06 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D46668238

Jun 13 '23 22:06 facebook-github-bot

@inseokhwang I see the diff has been abandoned. Should I close this PR ?

Jul 27 '23 13:07 vsiles

Hi @inseokhwang!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Jul 04 '24 01:07 facebook-github-bot