nailgun
nailgun copied to clipboard
Tidy up and bug fixes
Well, as I tried this, I stepped upon a few problems:
- Missing documentation, hence I updated the readme.
- A few missing @Override and @FunctionalInterface.
- Public attributes in NGContext, hence I added getter (the setter were already there).
- Problems with the Classloader stuff on Java ~8~ 11, hence it fixed that.
- mvn version not set to a SNAPSHOT
- A few missing
flush()
. -
ng-version
command not working in development setup. - Some errors (like ClassNotFound) not propagated to client.
I decided to fix all that.
Hi @aanno!
Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.
In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
@aanno This PR should split into multiple ones. Could you do it? Thanks.
Ok, first round:
- improve documentation: #187
- new mvn SNAPSHOT version: #188
- refactoring: #189
After these 3 are accepted, I will work on the rest.