nailgun icon indicating copy to clipboard operation
nailgun copied to clipboard

Tidy up and bug fixes

Open aanno opened this issue 4 years ago • 4 comments

Well, as I tried this, I stepped upon a few problems:

  1. Missing documentation, hence I updated the readme.
  2. A few missing @Override and @FunctionalInterface.
  3. Public attributes in NGContext, hence I added getter (the setter were already there).
  4. Problems with the Classloader stuff on Java ~8~ 11, hence it fixed that.
  5. mvn version not set to a SNAPSHOT
  6. A few missing flush().
  7. ng-version command not working in development setup.
  8. Some errors (like ClassNotFound) not propagated to client.

I decided to fix all that.

aanno avatar Mar 21 '20 17:03 aanno

Hi @aanno!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 21 '20 17:03 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Mar 21 '20 18:03 facebook-github-bot

@aanno This PR should split into multiple ones. Could you do it? Thanks.

v-jizhang avatar Apr 06 '20 20:04 v-jizhang

Ok, first round:

  • improve documentation: #187
  • new mvn SNAPSHOT version: #188
  • refactoring: #189

After these 3 are accepted, I will work on the rest.

aanno avatar Apr 30 '20 15:04 aanno