metro icon indicating copy to clipboard operation
metro copied to clipboard

Fix expo issue [#17903](https://github.com/expo/expo/issues/17903)

Open gavin1995 opened this issue 3 years ago • 4 comments

Summary

Fix expo issue #17903

Test plan

dependencies

{ "expo": "45.0.5", "expo-location": "~14.2.2", "expo-navigation-bar": "~1.2.0", "expo-splash-screen": "~0.15.1", "expo-status-bar": "~1.3.0", "expo-updates": "~0.13.2", "react-native": "0.68.2" }

issue

The file in the _symbolicate method may be a url link.

gavin1995 avatar Jul 01 '22 03:07 gavin1995

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 01 '22 10:07 facebook-github-bot

Need it soon :)

edi avatar Jul 12 '22 15:07 edi

Please review this PR, we also need it

nicusbonannus avatar Jul 15 '22 15:07 nicusbonannus

Also needed

tybeck avatar Aug 20 '22 23:08 tybeck

Codecov Report

Base: 79.73% // Head: 79.73% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (8585d13) compared to base (736de64). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
- Coverage   79.73%   79.73%   -0.01%     
==========================================
  Files         210      210              
  Lines       10671    10673       +2     
  Branches     2584     2585       +1     
==========================================
+ Hits         8509     8510       +1     
- Misses       2162     2163       +1     
Impacted Files Coverage Δ
packages/metro/src/Server.js 87.25% <100.00%> (-0.19%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Dec 24 '22 21:12 codecov-commenter

On closer investigation, Metro already makes an attempt to check for known URLs here but it was buggy - #910.

robhogan avatar Dec 26 '22 18:12 robhogan

Thanks again @gavin1995, closing as this is superseded by #910, now released in 0.74.0.

robhogan avatar Jan 09 '23 14:01 robhogan