fix: handle http scenario for pathToSource in _processDebuggerGetScri…

[wood1986]

fix #832

Summary

Test plan

[facebook-github-bot]

@jacdebug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[motiz88]

Hey @wood1986, thanks for the PR! Unfortunately I don't think this is the right solution - the client should perform this fetch, not the inspector proxy (which is part of the server). This only works based on assumptions on external conditions, e.g. that http://localhost:8081 on the client device happens to be forwarded to port 8081 on the server.

[wood1986]

I deleted my previous comment because it was wrong.

Hey @motiz88

I have just realized Debugger.getScriptSource is a standard Chrome DevTool protocol.

Flipper < - > Chrome DevTool < - > metro

Chrome DevTool is just an iframe inside Flipper. Flipper initializes Chrome DevTool. After that, Flipper does not have a role. Chrome DevTool will directly deal with Metro via ws and it does not hit metro middleware

How to tell flipper to hit http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rn0682&modulesOnly=false&runModule=true&cachePrevention=1 directly?

[wood1986]

Just ping again in case you forget after the weekend

[wood1986]

Any update??

[wood1986]

Hey @motiz88, could you please follow up this PR and my latest reply? Thanks

[raon0211]

This seems to be fixed from v0.73.0.

https://github.com/facebook/metro/commit/db19b06bdd6d2fbbe109e4f3be4b3af3489c1f1c