mcrouter icon indicating copy to clipboard operation
mcrouter copied to clipboard

Fix OSS build

Open markbhasawut opened this issue 3 weeks ago • 0 comments

D89334763 introduced the use of include "thrift/annotation/thrift.thrift" in carbon_result.thrift.

Making all in carbon
make[4]: Entering directory '/home/runner/work/mcrouter/mcrouter/mcrouter/lib/carbon'
/home/runner/work/mcrouter/mcrouter/mcrouter-install/install/bin//thrift1  -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ carbon_result.thrift
/home/runner/work/mcrouter/mcrouter/mcrouter-install/install/bin//thrift1  -gen mstch_cpp2:stack_arguments,sync_methods_return_try,include_prefix=mcrouter/lib/carbon/ -I /home/runner/work/mcrouter/mcrouter/mcrouter-install/install/include/ carbon.thrift
[ERROR:carbon_result.thrift:8] Could not find include file thrift/annotation/thrift.thrift
make[4]: *** [Makefile:521: gen-cpp2/carbon_result_data.h] Error 1
make[4]: *** Waiting for unfinished jobs....

This should be fixed by -I $(INSTALL_DIR)/include/ for generating gen-cpp2 for carbon_result.thrift.

D89393569 exposed the component of Tupperware which is a Meta-only tool, so guarding the section related to TW with MCROUTER_OSS_BUILD to fix the issue for OSS build.

markbhasawut avatar Dec 19 '25 11:12 markbhasawut