mcrouter icon indicating copy to clipboard operation
mcrouter copied to clipboard

Build for Debian stretch

Open kelu27 opened this issue 7 years ago • 2 comments

Hi, I want to improve Mcrouter build system for debian stretch. For the moment folly and wangle commits are hardcoded in dockerbuild/Dockerfile. Where can we put those references? It was easier where they were located directly in mcrouter folder.

Thx

kelu27 avatar Jan 14 '19 14:01 kelu27

Hi @kelu27, When I packaged the latest release I hard-coded the commits in the dockerbuild/Dockerfile, but I later realized that those "*_COMMIT" files (only) exist in the release branch, like here: https://github.com/facebook/mcrouter/tree/release-39-0/mcrouter

orishu avatar Jan 14 '19 17:01 orishu

Ok so for a more generic build we need to download the vX.X.X-release tag and get "*_COMMIT" files from here, right?

kelu27 avatar Jan 17 '19 10:01 kelu27