mariana-trench icon indicating copy to clipboard operation
mariana-trench copied to clipboard

Does not compile with latest fmt 9.1 due to lack of formatter for types

Open rickmark opened this issue 2 years ago • 1 comments

Bug

Bug description fmt/core.h:1756:3: error: static_assert failed due to requirement 'formattable' "Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt"

Reproduction steps Build with fmt 9.1

Expected behavior Give a clear and concise description of what you expected to happen.

Logs

Output goes here

Additional context Add any other context about the problem here.

rickmark avatar Feb 23 '23 22:02 rickmark

Same issue with fmt 8.1.1 (is the documentation and versions mentioned here : https://mariana-tren.ch/docs/contribution/ still up to date) ?

Update: Just saw that the python install script use fmt 7.1.3 https://github.com/facebook/mariana-trench/blob/main/scripts/build_static_binary.py#L31 (and it worked with this version.)

2Dai avatar May 01 '23 14:05 2Dai