lexical icon indicating copy to clipboard operation
lexical copied to clipboard

[lexical-playground] Feature: columns resizing in layouts plugin

Open harshmetkel24 opened this issue 1 year ago • 4 comments

[lexical-playground] Feature: support to add new columns side by side and column resize

Description

  • Currently when adding Columns Layout promt asks to chose number of columns. But once added there is no way to add more columns or even resizing already added columns. If someone wants to change something they have to start fresh. Also there is no way to free resize columns, can only chose from predefined options.
  • After this change users will be able to add more columns to end by clicking on + button. This behaviour is adapted from lexical-table only. Also user's can resize columns according to their need.

Closes #6740

Before

image

No option to add new columns or resize existing ones

After

https://github.com/user-attachments/assets/c8f2ed1f-1a8e-4ad3-831e-e0ba6e5318b1

Now users can add more columns and resize them as well according to their need

harshmetkel24 avatar Nov 01 '24 15:11 harshmetkel24

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:45am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:45am

vercel[bot] avatar Nov 01 '24 15:11 vercel[bot]

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.59 KB (0%)
@lexical/rich-text - esm 31.63 KB (0%)
@lexical/plain-text - cjs 37.22 KB (0%)
@lexical/plain-text - esm 28.94 KB (0%)
@lexical/react - cjs 40.32 KB (0%)
@lexical/react - esm 33.01 KB (+0.01% 🔺)

github-actions[bot] avatar Nov 01 '24 15:11 github-actions[bot]

I don't want to discourage the development of this plugin, but I think it might make more sense to have this one in a separate repo, vs inside the playground and we can list a number of other plugins people have built in the documentation.

ivailop7 avatar Nov 05 '24 23:11 ivailop7

there seems to be a regression for this test: packages/lexical-playground/tests/e2e/Tables.spec.mjs:3743:3 › Tables › Paste and insert new lines after unmerging cells https://github.com/facebook/lexical/actions/runs/11691145148/job/32797500364?pr=6787

potatowagon avatar Nov 11 '24 10:11 potatowagon

there seems to be a regression for this test: packages/lexical-playground/tests/e2e/Tables.spec.mjs:3743:3 › Tables › Paste and insert new lines after unmerging cells https://github.com/facebook/lexical/actions/runs/11691145148/job/32797500364?pr=6787

will look into this

harshmetkel24 avatar Nov 21 '24 07:11 harshmetkel24