lexical icon indicating copy to clipboard operation
lexical copied to clipboard

[lexical] Bug Fix: spliting AutoLinkNode

Open strdr4605 opened this issue 1 year ago • 5 comments

Description

Closes #6628

Test plan

Before

https://github.com/facebook/lexical/issues/6628

After

https://github.com/user-attachments/assets/de32f92b-c246-41db-b82c-e12657414588

strdr4605 avatar Sep 13 '24 09:09 strdr4605

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:04am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:04am

vercel[bot] avatar Sep 13 '24 09:09 vercel[bot]

size-limit report 📦

Path Size
lexical - cjs 29.77 KB (0%)
lexical - esm 29.6 KB (0%)
@lexical/rich-text - cjs 38.24 KB (0%)
@lexical/rich-text - esm 31.46 KB (0%)
@lexical/plain-text - cjs 36.82 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.01 KB (0%)
@lexical/react - esm 32.93 KB (0%)

github-actions[bot] avatar Sep 13 '24 09:09 github-actions[bot]

from the e2e test results, there seems to be a regression for copy paste

potatowagon avatar Sep 25 '24 00:09 potatowagon

From the e2e test results, there seems to be a regression for copy paste

Hey @potatowagon, thanks for checking this PR. Before moving on try to fix the regression for copy-paste. I would like to know if the fix is good enough. I did the fix mostly to start a discussion around this issue and see that is the best solution.

strdr4605 avatar Sep 25 '24 05:09 strdr4605

While trying to debug the failing tests I see a strange behavior of the editor in the test and reproducing it manually

image

Here my trying to do the same as the test

https://github.com/user-attachments/assets/d64296ad-9bbb-4ccd-9a96-5af96d08be87

The result is different. What am I missing?

strdr4605 avatar Sep 25 '24 12:09 strdr4605