facebook
[lexical-yjs] init collabNode in nested composer with existing state
Description
When nested composer has state and connects to collab binding's collabNodeMap stays empty. As result synchronization with remote is not fired.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 4:17am |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 13, 2024 4:17am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @ololoken!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
size-limit report 📦
| Path | Size |
|---|---|
| lexical - cjs | 28.5 KB (0%) |
| lexical - esm | 28.31 KB (0%) |
| @lexical/rich-text - cjs | 36.94 KB (0%) |
| @lexical/rich-text - esm | 28.16 KB (0%) |
| @lexical/plain-text - cjs | 35.59 KB (0%) |
| @lexical/plain-text - esm | 25.46 KB (0%) |
| @lexical/react - cjs | 38.82 KB (0%) |
| @lexical/react - esm | 29.43 KB (0%) |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hi!
Can you pls elaborate on the issue? How to reproduce it now?
And would it be possible to cover fix with tests to prevent regression?
Without tests and/or some kind of demonstration of the issue that this intends to solve it's hard to accept. Please re-open when and if you intend to provide enough details for this to be properly reviewed.
