facebook
[Lexical] Bug Fix: backspace bug when deleting nodes with `canInsertTextAfter` set to false
Description
On Android Chrome, due to changes on #5644, nodes with canInsertTextAfter set to false don't delete the last character when pressing backspace (e.g. MentionNode, KeywordNode; see #5364).
The PR avoids delegating deletion to the browser on those cases.
Closes #5364
Steps to recreate
- On Android Chrome, goto https://playground.lexical.dev/
- Type @ and mention someone, or write a Keyword (e.g.
congrats) - Hit backspace to delete the mention/keyword
- Bug: the last character is not deleted and the cursor moves back one position
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 20, 2024 5:03pm |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 20, 2024 5:03pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @dani-lp!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
size-limit report 📦
| Path | Size |
|---|---|
| lexical - cjs | 30.85 KB (0%) |
| lexical - esm | 30.73 KB (0%) |
| @lexical/rich-text - cjs | 39.58 KB (0%) |
| @lexical/rich-text - esm | 32.67 KB (0%) |
| @lexical/plain-text - cjs | 38.22 KB (0%) |
| @lexical/plain-text - esm | 29.93 KB (0%) |
| @lexical/react - cjs | 41.35 KB (0%) |
| @lexical/react - esm | 34.03 KB (0%) |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
LGTM but it would be awesome to have a test for this... At least unit one
I'm not familiar with testing Lexical and I haven't found any tests in the codebase that cover the onBeforeInput function, so I'm not sure how to test this. Could you please give me some pointers for this?
Hey there, on the current playground.lexical.dev (I believe with Lexical 0.20.0 at the time of writing) the issue on Android is still easily reproducible. Would it be possible to merge this one? I saw a request for a unit test above but a unit test won't be able to emulate the Android Chrome environment properly anyway, yet the issue is still very annoying. We have to patch lexical manually with every new release in order to make it work.
