lexical
lexical copied to clipboard
facebook
Fix OverflowNode configuration
OverflowNode was badly configured, this was revealed by https://github.com/facebook/lexical/pull/6025. It is always inline and can't be empty. Surprisingly, the current configuration was passing all tests fine but the video below show some surprisingly bad behavior when we only fix isInline, we can't have dangling empty span.
Before:
https://github.com/facebook/lexical/assets/193447/7915df5e-944d-49d6-80ca-b9c6061a3434
After:
https://github.com/facebook/lexical/assets/193447/0b39fd28-794d-4a15-bafa-a98d0d76876a
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 14, 2024 2:35pm |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 14, 2024 2:35pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
size-limit report 📦
| Path | Size |
|---|---|
| lexical - cjs | 29.38 KB (0%) |
| lexical - esm | 29.24 KB (0%) |
| @lexical/rich-text - cjs | 37.74 KB (0%) |
| @lexical/rich-text - esm | 31.05 KB (0%) |
| @lexical/plain-text - cjs | 36.41 KB (0%) |
| @lexical/plain-text - esm | 28.42 KB (0%) |
| @lexical/react - cjs | 39.59 KB (0%) |
| @lexical/react - esm | 32.53 KB (0%) |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
#6456 may also fix this incidentally because it adds a transform to prevent empty OverflowNode
