facebook
[lexical-playground] Bug Fix: Added blur event
Description
Current behaviour - > Font size was not changing even after changing the input size field. Modified behaviour -> triggered the blur event, because of that font is changing as soon as we blur out of the input box. Describe the changes in this pull request
Closes: #6000
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| lexical | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 4, 2024 4:27am |
| lexical-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 4, 2024 4:27am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @CARPEDIEM05!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Hi, I'm not sure if we want to update the font size on blur event. We want to update the font size only when the user presses the enter key or any of the +/- buttons. However, it would be nice to revert to current font size value in the input field, if the user removes focus from the font input entry without pressing enter. In other words, the font size input field, when not in focus, should always show the selection font size.
Hi @Shubhankerism, can you review this? I have updated the code according to the prev value if it is not committed by the user.
Hi @Shubhankerism , I tested the changes and you are right. Thank you so much for the suggestions.