lexical icon indicating copy to clipboard operation
lexical copied to clipboard

When creating a new check list, set the `checked` value of the list item to `false` instead of `undefined`

Open amanharwara opened this issue 1 year ago • 1 comments

At the moment, when creating a new checklist, the newly created list item doesn't have the checked set until the user manually toggles it. This PR makes sure that the checked value is set to false and not undefined. This also makes the behavior in line with the behavior when creating a check list using the markdown transformer.

https://github.com/facebook/lexical/assets/8348101/a065966a-ceae-4ce4-bf11-250a041efd0f

amanharwara avatar Apr 27 '24 12:04 amanharwara

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:54am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:54am

vercel[bot] avatar Apr 27 '24 12:04 vercel[bot]

packages/lexical-playground/tests/e2e/List.spec.mjs:1170:3 › Nested List › Can create check list, toggle it to bullet-list and back

is breaking

potatowagon avatar May 28 '24 01:05 potatowagon

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.77 KB (0%)
@lexical/rich-text - esm 28.1 KB (0%)
@lexical/plain-text - cjs 35.35 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.51 KB (0%)
@lexical/react - esm 29.12 KB (0%)

github-actions[bot] avatar Jun 05 '24 08:06 github-actions[bot]

Sorry for the long delay. Should be fixed now.

amanharwara avatar Jun 05 '24 08:06 amanharwara