lexical icon indicating copy to clipboard operation
lexical copied to clipboard
verified publisher icon facebook

Fix: #5974 Cursor jump to the end of the document when a collaborator deletes focusing paragraph

Open matsuyama-k1 opened this issue 1 year ago • 5 comments

fixed #5974

https://github.com/facebook/lexical/assets/111737064/9b4bccee-23d8-447c-aacd-4da0cdbfe659

matsuyama-k1 avatar Apr 27 '24 07:04 matsuyama-k1

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:51am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:51am

vercel[bot] avatar Apr 27 '24 07:04 vercel[bot]

@fantactuka could you look into this one, would really like to land this one before the next release.

ivailop7 avatar Apr 27 '24 17:04 ivailop7

This is great! Can you pls add a test for this fix? To prevent regression

StyleT avatar Apr 29 '24 17:04 StyleT

I added a test and fixed! It looks like integrity test is failed because Collaboration.test.ts is not completely typed.

matsuyama-k1 avatar May 07 '24 05:05 matsuyama-k1

A more generic fix was merged here: https://github.com/facebook/lexical/commit/b5fa87d0c6e92fb38f9cb484a7340ab41eff1186

ivailop7 avatar May 19 '24 18:05 ivailop7