lexical icon indicating copy to clipboard operation
lexical copied to clipboard

[RFC] Lexical update retain selection when no event

Open zurfyx opened this issue 2 years ago • 6 comments

You unfocus the editor, editor._editorState._selection retains selection, you trigger

editor.dispatchCommand

Selection is lost.

Doesn't feel right. This PR addresses this.

Putting as RFC for now as there's no tests and want to double check this wasn't intended to cover some other case.

zurfyx avatar Jul 24 '23 20:07 zurfyx

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 11:17pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 9, 2024 11:17pm

vercel[bot] avatar Jul 24 '23 20:07 vercel[bot]

size-limit report 📦

Path Size
lexical - cjs 28.31 KB (0%)
lexical - esm 28.13 KB (0%)
@lexical/rich-text - cjs 36.77 KB (0%)
@lexical/rich-text - esm 28.09 KB (0%)
@lexical/plain-text - cjs 35.36 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.51 KB (0%)
@lexical/react - esm 29.14 KB (0%)

github-actions[bot] avatar Jul 24 '23 20:07 github-actions[bot]

Note the failing UTs

acywatson avatar Jul 24 '23 21:07 acywatson

🚢🚢🚢

fantactuka avatar Jul 25 '23 01:07 fantactuka

🚢🚢🚢

acywatson avatar Jul 26 '23 03:07 acywatson

merged main into the branch, curious if this is still a legit fix, seems like one? @zurfyx

ivailop7 avatar Jun 09 '24 23:06 ivailop7

Closing this PR due to staleness! If there are new updates, please reopen the PR.

github-actions[bot] avatar Nov 11 '24 09:11 github-actions[bot]