lexical icon indicating copy to clipboard operation
lexical copied to clipboard

AutoLink should also respect the default behavior of toogle link command

Open WinmezzZ opened this issue 1 year ago • 7 comments

AutoLink should also respect the default behavior of toogle link.

AutoLink Plugin is a nice plugin when we need transform a http url to an html link element, but sometimes we want to cancel the link for an url, just for showing but not allowed to click

https://github.com/facebook/lexical/assets/40154766/f412ca3e-b404-41b2-afc6-e26dfc2002e8

WinmezzZ avatar Jun 19 '23 08:06 WinmezzZ

I want to work on this issue please assign me this.

ankitpawar03 avatar Jun 19 '23 10:06 ankitpawar03

@ankitpawar03 Happy for you to take a look. Assigned it to you.

thegreatercurve avatar Jun 19 '23 11:06 thegreatercurve

@ankitpawar03 Happy for you to take a look. Assigned it to you.

I ran it on my local system and searched on the source code but couldn't get how to disable auto-link, can you help me with it?

ankitpawar03 avatar Jun 19 '23 19:06 ankitpawar03

@ankitpawar03 Happy for you to take a look. Assigned it to you.

Thank you for giving me this opportunity, but I am unable to resolve this issue yet, so I am unassigning myself from this...

ankitpawar03 avatar Jun 20 '23 08:06 ankitpawar03

@thegreatercurve, Hey, I was working on this issue but realised that even if we toggle the auto link, it will automatically going to consider it again. I mean, we might need to consider it auto-link for the first time but somehow need to ignore it for the second time.

Infinity8sailor avatar Jun 27 '23 20:06 Infinity8sailor

@thegreatercurve, Hey, I was working on this issue but realised that even if we toggle the auto link, it will automatically going to consider it again. I mean, we might need to consider it auto-link for the first time but somehow need to ignore it for the second time.

Have this approach been given up on?

It is how I would expect it to work. Not having the ability to have both 1) auto link copy/pasted links and 2) remove the anchor is poor UX. Ideally both is possible through this approach.

hazirmagron avatar May 03 '24 11:05 hazirmagron

It looks like the problem was solved here https://github.com/facebook/lexical/issues/5607

is that right?

juliana-samoilenko avatar Sep 09 '24 07:09 juliana-samoilenko