infer
infer copied to clipboard
facebook
Handle static closure calls
This PR aims at handling static closure calls like regular static function calls. For instance, this allows for static closure calls to be present in the syntactic callgraph (which would not be the case otherwise).
Hi @MaelCravero!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@jvillard has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Are the biabduction changes relevant to you? If not it would be simpler to drop them to avoid breaking something there by accident. We don't have large-scale tests for biabduction anymore as we have stopped using it in production (replaced by Pulse).
The changes in /biabduction are only in Errdesc, to capture cases where a closure was used instead of a regular function. So it should be very safe. But we have recently abandoned BO on our side, so we could actually drop this patch too.
