JsonReports.ml: fix --report-force-relative-path being ignored

Open glacambre opened this issue 2 years ago • 2 comments

This commit fixes an issue originally found through AdaCore's Ada frontend for infer, but which is actually present for other frontends too.

The issue is that infer will sometimes emit absolute paths in its JSON report file despite --report-force-relative-path being present on the command line. This issue can be reproduced with infer's C frontend like this:

mkdir -p repro/child cd repro/child cat > ../file.c <<EOF void main() { int A, B = 1; A = A + B; } EOF cat > Makefile <<EOF all: ../file.c gcc ../file.c EOF infer run --report-force-relative-path --quiet -- make grep -o '"file[^"]":"[^"]"' infer-out/report.json

Please see CONTRIBUTING.md for how to set up your development environment and run tests.

May 19 '22 10:05 glacambre

Hi @glacambre!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!