infer
infer copied to clipboard
facebook
Win32 (MinGW) support
This PR implements nearly all that's required to have Win32 support of Infer. As a disclaimer, we (AdaCore) are only using the MinGW port. I cannot really say whether those commits help for a Cygwin or MSVC build. In any case, most of the new tests are for Win32, hence do not activate under Cygwin.
This branch is almost feature-complete. The only missing commit is the one replacing Core by Core_kernel. It is ready on our end, but needs a bit of cleanup before being sent here. In the meantime, all those commits should be ok independently, in particular under Linux.
The "meat" of the patch is the commit entitled "Reimplement tasking without the use of fork()". Everything else is also important at different levels, but significantly less so. Close seconds are the commits "Use mode O_SHARE_DELETE when opening files" and "Add a notion of retries to database serialization", as the current implementation of "atomic-rename for summaries" does not work well under Windows.
GitHub ate my overall comment (I was trying to comment on an individual commit but apparently that's not what GitHub does...).
Broadly in support of all these changes, looks pretty good, thanks! I have a few questions as you can see.
With 5a5349b1b392692df03dabb9b750b4943fa7cad6 the Unix-specific parts of Core are more clearly split into various _unix modules, which should simplify the job of this PR.
Thanks for the info! As it happens, we are trying to merge to last-week's main branch 😅 . (And so we did not see this commit.) I will check whether Core 15.0 is actually compatible with our own version of OCaml. If so, I will start reviving this MR.