igl icon indicating copy to clipboard operation
igl copied to clipboard

Single Pass Stereo has left/right eye colour disparity on Quest Pro

Open BattleAxeVR opened this issue 11 months ago • 4 comments

FYI, there's something weird between the eyes using single pass stereo mode, on Quest Pro. I will test it on my other Quests to confirm.

BattleAxeVR avatar Mar 20 '24 00:03 BattleAxeVR

image

This is on Quest 3. This isn't a screenshot, but a picture I took using my phone, through the lens.

Left eye = box is red (mono) = INCORRECT Right eye = box is yellow (and in colour) = CORRECT

Repro steps:

  1. Put on any Quest Headset.
  2. Start the app, in either GL ES or Vulkan mode
  3. Inspect colours visually don't match by opening and closing one eye at a time.

The order of 1 and 2 can be swapped.

It is the same in GL ES and Vulkan mode.

image

image

The bug is different whether you use useSinglePassStereo_ = true or false.

Setting it to false shows both eyes seeing a red box in both eyes, which is, also, I believe, incorrect (both eyes should show a yellow box, with distinct colours in the swatches).

Clearly something is wrong here. This is 100% repro.

BattleAxeVR avatar Mar 29 '24 07:03 BattleAxeVR

@corporateshark sorry to bug ya, any chance of getting this looked at?

BattleAxeVR avatar Apr 15 '24 21:04 BattleAxeVR

@BattleAxeVR It is definitely on our TODO list to look at it. What we lack is the capacity, so I cannot promise any exact date for it.

corporateshark avatar Apr 15 '24 23:04 corporateshark

Thanks, no problem

BattleAxeVR avatar Apr 15 '24 23:04 BattleAxeVR

I can confirm this issue when running on Quest 3, example build on MacOs Sonoma.

karlll avatar May 05 '24 19:05 karlll

I've submitted #115 that fixes the flickering (tested on Quest 3), but I'm not sure whether the gl_ViewID_OVR in the color channel was supposed to do something that I'm to ignorant to realise :)

karlll avatar May 06 '24 18:05 karlll

I'll test it shortly, thanks!

BattleAxeVR avatar May 06 '24 20:05 BattleAxeVR

works!

BattleAxeVR avatar May 07 '24 03:05 BattleAxeVR

just close this issue after the PR is merged (or I can do it)

BattleAxeVR avatar May 07 '24 03:05 BattleAxeVR

nb I tested it in single and multipass stereo, both are fine.

I suppose the point of putting that view ID in the green channel in the first place was to test if the multipass index actually working, come to think of it.

BattleAxeVR avatar May 07 '24 03:05 BattleAxeVR

@BattleAxeVR thanks for checking this! I will merge the PR.

corporateshark avatar May 07 '24 04:05 corporateshark

Fixed via https://github.com/facebook/igl/pull/115.

corporateshark avatar May 07 '24 07:05 corporateshark